Run robot driver test also with tf_prefix #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like automatically testing this, but would prefer to not copy the controller config for it. I think we should be able to use |
RobertWilbrandt
approved these changes
Jul 12, 2023
|
@fmauch can you take a look if this change seems ok to you? |
|
Thank you @RobertWilbrandt that's a very good addition! |
mergify bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Run robot driver test also with tf_prefix * Use tf_prefix substitution in controllers config file * Set default value of tf_prefix in launchfile to empty instead of '""' --------- Co-authored-by: Robert Wilbrandt <[email protected]> (cherry picked from commit 79bfddc)
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Run robot driver test also with tf_prefix * Use tf_prefix substitution in controllers config file * Set default value of tf_prefix in launchfile to empty instead of '""' --------- Co-authored-by: Robert Wilbrandt <[email protected]> (cherry picked from commit 79bfddc)
fmauch
added a commit
that referenced
this pull request
Jul 21, 2023
* Run robot driver test also with tf_prefix * Use tf_prefix substitution in controllers config file * Set default value of tf_prefix in launchfile to empty instead of '""' --------- Co-authored-by: Robert Wilbrandt <[email protected]> (cherry picked from commit 79bfddc)
fmauch
added a commit
that referenced
this pull request
Jul 21, 2023
* Run robot driver test also with tf_prefix * Use tf_prefix substitution in controllers config file * Set default value of tf_prefix in launchfile to empty instead of '""' --------- Co-authored-by: Robert Wilbrandt <[email protected]> (cherry picked from commit 79bfddc) Co-authored-by: Felix Exner (fexner) <[email protected]>
RobertWilbrandt
pushed a commit
that referenced
this pull request
Aug 9, 2023
* Run robot driver test also with tf_prefix * Use tf_prefix substitution in controllers config file * Set default value of tf_prefix in launchfile to empty instead of '""' --------- Co-authored-by: Robert Wilbrandt <[email protected]> (cherry picked from commit 79bfddc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test (parametrizes the existing test) that also runs the driver with a tf_prefix. This closes #726.
This also serves as an example for a modified controller configuration when using a tf_prefix.